Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪝 Set up pre-commit checks #341

Merged
merged 11 commits into from
Nov 27, 2023
Merged

🪝 Set up pre-commit checks #341

merged 11 commits into from
Nov 27, 2023

Conversation

marcelwa
Copy link
Collaborator

@marcelwa marcelwa commented Nov 27, 2023 •
edited
Loading

Description

This PR sets up pre-commit checks for the repository. They are automatically run on the repo on every push. Additionally, you can install them on your machine such that they are already run on local commits.

Installation:

pip install pre-commit

In your cloned fiction folder:

pre-commit install

Done ✅

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@marcelwa marcelwa added the enhancement New feature or request label Nov 27, 2023
@marcelwa marcelwa self-assigned this Nov 27, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 27, 2023 •
edited
Loading

Codecov Report

Merging #341 (7d7fe10) into main (8e61624) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #341      +/-   ##
==========================================
- Coverage   96.06%   96.05%   -0.01%     
==========================================
  Files         102      102              
  Lines       10086    10086              
==========================================
- Hits         9689     9688       -1     
- Misses        397      398       +1

see 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e61624...7d7fe10. Read the comment docs.

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@marcelwa marcelwa merged commit 481331f into main Nov 27, 2023
58 checks passed
@marcelwa marcelwa deleted the pre-commit-hooks branch November 27, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marcelwa marcelwa

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marcelwa